Implement FactoryGirl #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a spec for this scenario? Thanks for the patch. |
|
As I said before, I had planned to write specs for it, but I wasn't able to run the existing suite... In the Rakefile, you have: require "rspec/core/rake_task" # RSpec 2.0
RSpec::Core::RakeTask.new(:spec) do |t|
t.pattern = 'spec/*_spec.rb'
# TODO this leaves out the specs on the library itself
endWhen I run |
|
Hm, looks like the specs are totally broken. I'll take this patch and fix the tests later. |
|
Okay. Feel free to ping me at that time to write specs, if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented annotation of FactoryGirl factories, here. It works fine as long as you use the
(test|spec)/factories/#{model_name}s.rbpattern. I don't intend to use the single file approach [spec/factories.rb], myself, and I would guess implementing annotation of that file would be significantly more involved, so I haven't done that bit, yet. Also, you'll have to keep your factories for a given table within one factory file.I didn't write any specs for it, because it seems you're not using them at present. I couldn't figure out exactly what was happening with that. (If you'd like me to add some Specs, please let me know and tell me how to run them given the Rakefile.)